0.4.7 (older version) Thoroughness: Medium Understanding: Medium
by HeroicKatora on 2020-12-27
This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.
The current version of SolKit is 1.0.1.
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.
To review the actual code of the crate, it's best to use cargo crev open solkit. Alternatively, you can download the tarball of solkit v1.0.1 or view the source online.
No unsafe code. This review includes the binary which does some file IO. I believe one might get the binary to overwrite arbitrary files by symbolically linking files (and the binary) such that they are located next to each other. This puts it into a
portablemode, which means it does not only write to its own XDG directories. Not a real problem as that works for a lot of applications.