0.2.2 (older version) Thoroughness: Low Understanding: Medium
by derekdreery on 2021-12-14
This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev
.
The current version of dBase is 0.6.0.
0.2.2 (older version) Thoroughness: Low Understanding: Medium
by derekdreery on 2021-12-14
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.
To review the actual code of the crate, it's best to use cargo crev open dbase
. Alternatively, you can download the tarball of dbase v0.6.0 or view the source online.
I read through the whole source, looking for malicious or dangerous code, and found none. There was one use of
unsafe
, which I checked for correctness w.r.t. memory access and integer overflow, and found no issues. I didn't review how well the crate performed its intended function, although I use the crate and it works for me.