0.2.1 (older version) Thoroughness: High Understanding: High
by git.jcg.re/jcgruenhage/crev-proofs.git on 2021-01-30
This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.
The current version of yggdrasil-keys is 0.3.0.
Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.
To review the actual code of the crate, it's best to use cargo crev open yggdrasil-keys. Alternatively, you can download the tarball of yggdrasil-keys v0.3.0 or view the source online.
I've authored this and we've used it in production. We've had one overflow bug for a while, but we've not experienced any issues after fixing that one.
We had multiple people look over it by now, and we've not found any more issues. The keys generated by this work fine with yggdrasil-go, and after fixing that one bug we've not experienced any incompatibilites anymore.