0.1.10 (older version) Thoroughness: Medium Understanding: High
by pmembrey on 2022-10-26
This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.
The current version of wolfssl-sys is 1.0.0.
Lib.rs has been able to verify that all files in the crate's tarball, except Cargo.lock,
are in the crate's repository. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.
To review the actual code of the crate, it's best to use cargo crev open wolfssl-sys. Alternatively, you can download the tarball of wolfssl-sys v1.0.0 or view the source online.
The crate tarball contains, among others, these files:
- obscure autoconf code, 325KB: wolfssl-src/configure.ac
- obscure autoconf code, 2KB: wolfssl-src/wolfcrypt/user-crypto/configure.ac
I'm the owner of the crate. Currently it is a thin '-sys' binding for WolfSSL. It uses a stored copy of WolfSSL that was downloaded directly from their github repository.
As it is a raw C binding, the functions are all 'unsafe' and that should be taken into account before considering the crate as it.