Code reviews of the which crate // Lib.rs

These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.

The current version of which is 6.0.1.

5.0.0 — diff review from 4.4.0 only (older version) safe-to-run

From bytecodealliance/wasmtime. By Alex Crichton.

Only one unsafe block, it's what a which crate is expected to be.

5.0.0 (older version) unknown

From kornelski/crev-proofs copy of git.savannah.gnu.org.

Packaged for Guix (crates-io)

4.4.2 — diff review from 4.4.0 only (older version) safe-to-deploy

From zcash/rust-ecosystem copy of zcash/zcash. By str4d.

Crate now has #![forbid(unsafe_code)], replacing its last unsafe block with a dependency on the rustix crate.

4.4.0 (older version) safe-to-run

From EmbarkStudios/rust-ecosystem. By Embark.

Small build-time crate to find path of binary. Single unsafe usage, file system access, both look sound

4.4.0 — diff review from 4.3.0 only (older version) safe-to-deploy

From zcash/rust-ecosystem copy of zcash/zcash. By Jack Grigg.

New APIs are remixes of existing code.

4.0.2 (older version) safe-to-run

From google/supply-chain copy of chromium. Audited without comment by Android Legacy.

cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.

safe-to-run

This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…

safe-to-deploy (implies safe-to-run)

This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…

unknown

May have been packaged automatically without a review

These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of which is 6.0.1.

4.3.0 (older version) Rating: Positive Thoroughness: Low Understanding: Medium

by matthiasbeyer on 2022-09-22

Minor changes to the windows parts (did not look too closely). Most prominent change seems to be lazy_static to be relaced with once_cell.

4.2.5 (older version) Rating: Positive Thoroughness: Medium Understanding: Medium

by matthiasbeyer on 2022-09-22

Show review…

Only one instance of unsafe code which seems ok to me (though I am not experienced with unsafe code). Did not have a look at the cfg(windows) code parts.

3.1.1 (older version) Rating: Positive Thoroughness: Low Understanding: Medium

by gitlab.com/njam on 2020-04-30

Clearly structured, well documented code

Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.

To review the actual code of the crate, it's best to use cargo crev open which. Alternatively, you can download the tarball of which v6.0.1 or view the source online.