Code reviews of the web-time crate // Lib.rs

These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of web-time is 1.1.0.

1.0.0 (older version) Rating: Positive Thoroughness: Low Understanding: Medium

by kpreid on 2024-01-26

Looks correct and generally good.

Nitpick: It uses a reexport pub use std::time::* (while shadowing Instant and SystemTime). This means that if std adds an item later, web_time will start reexporting it even if it needs a reimplementation instead. It would be more robust for web_time to reexport only an explicit list of items.

0.2.3 (older version) Rating: Positive Thoroughness: Low Understanding: Medium

by kpreid on 2023-12-25

Show review…

Looks correct and generally good.

Nitpick: the web module reexports pub use std::time::* (while shadowing Instant and SystemTime). This means that if std adds an item later, web_time will start exporting it even if it needs a reimplementation instead. It would be more robust for web_time to reexport using an explicit list.

This review is from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.

The current version of web-time is 1.1.0.

0.2.4 (older version) unknown

From kornelski/crev-proofs copy of git.savannah.gnu.org.

Packaged for Guix (crates-io)

cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.

unknown

May have been packaged automatically without a review

Lib.rs has been able to verify that all files in the crate's tarball, except Cargo.lock, are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.

To review the actual code of the crate, it's best to use cargo crev open web-time. Alternatively, you can download the tarball of web-time v1.1.0 or view the source online.