Lib.rs

› wait-timeout › Reviews

This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

0.2.0 (current) Rating: Positive Thoroughness: Medium Understanding: Medium

by Minoru on 2021-05-01

The crate implements a seemingly trivial thing: waiting for a child process to finish, with a timeout.

On Windows, this boils down to a single WinAPI call. I don't know much about Windows, but the code looks okay to me. There is a minor issue of timeouts being capped at ≈49 days, which I reported: https://github.com/alexcrichton/wait-timeout/issues/23

On Unix, the algorithm is much more involved. I understand it, and I believe it to be correct.

The crate calls into libc and WinAPI, so there are a bit of unsafe in here. But it all looks all right to me.

These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.

cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.

safe-to-run

This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…

does-not-implement-crypto (implies crypto-safe)

Inspection reveals that the crate in question does not attempt to implement any cryptographic algorithms on its own.

Note that certification of this does not require an expert on all forms of cryptography: it's expected for crates we import to be "good enough" citizens, so they'll at least be forthcoming if they try to implement something cryptographic. When in doubt, please ask an expert.

crypto-safe
Implied by other criteria

All crypto algorithms in this crate have been reviewed by a relevant expert.

Note: If a crate does not implement crypto, use does-not-implement-crypto, which implies crypto-safe, but does not require expert review in order to audit for.

unknown

May have been packaged automatically without a review

Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.

To review the actual code of the crate, it's best to use cargo crev open wait-timeout. Alternatively, you can download the tarball of wait-timeout v0.2.0 or view the source online.