Code review of the VRD crate // Lib.rs

This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

0.0.8 (current) Rating: Negative Thoroughness: None Understanding: Low

by kornelski on 2025-01-28

Mersenne Twister is not a good random algorithm, and this crate has tokio as a dependency, along with a fork of serde_yaml, custom loggers and datetime libraries! And it's still including the rand crate, which you should use instead.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.

To review the actual code of the crate, it's best to use cargo crev open vrd. Alternatively, you can download the tarball of vrd v0.0.8 or view the source online.