0.3.0 (current) Thoroughness: Low Understanding: Medium
by kornelski on 2021-11-16
These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.
The current version of tokio-retry is 0.3.0.
0.2.0 (older version) Thoroughness: Medium Understanding: Medium
by qnighy on 2019-08-24
No unsafe code. Does things it claims. We could perhaps have some refactorings but it already does its job pretty well.
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.
To review the actual code of the crate, it's best to use cargo crev open tokio-retry. Alternatively, you can download the tarball of tokio-retry v0.3.0 or view the source online.
The API of the exponential backoff strategy is surprising, as it uses the same number for the base and the exponent.