1.1.0 (older version) Thoroughness: Low Understanding: Medium
by HeroicKatora on 2019-08-30
This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.
The current version of Suffix is 1.3.0.
Lib.rs has been able to verify that all files in the crate's tarball, except Cargo.lock,
are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.
To review the actual code of the crate, it's best to use cargo crev open suffix. Alternatively, you can download the tarball of suffix v1.3.0 or view the source online.
As a side effect of the linear time requirements it also ensures that allocations are bounded. However, there is no built-in way to interoperate with any custom limits, precalculate required memory, or reuse allocations made separately before.