Lib.rs

› stl_io › Reviews

These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of stl_io is 0.8.5.

0.8.1 (older version) Rating: Positive Thoroughness: Medium Understanding: Medium

by kpreid on 2024-08-14

I have reviewed the code for reasonableness, not correctness. It is generally straightforward, though in a somewhat unusual style with a lot of absolute paths.

There is one unsafe code block, which is sound but unnecessary.

I have been successfully using this library to write STL files. I have not tested it for reading STL files.

Compared to the previous version I reviewed, 0.7.0,

  • There are no code changes (odd).
  • There is no changelog.
  • The license information has been clarified, but it is no longer under the Apache-2.0 license, only MIT.

0.7.0 (older version) Rating: Positive Thoroughness: Medium Understanding: Medium

by kpreid on 2024-08-14

Show review…

I have reviewed the code for reasonableness, not correctness. It is generally straightforward, though in a somewhat unusual style with a lot of absolute paths.

There is one unsafe code block, which is sound but unnecessary.

The license information is somewhat inconsistent, as it contains three license text files (GPL, Apache, and MIT) but the Cargo.toml specifies license = "Apache-2.0 OR MIT".

I have been successfully using this library to write STL files. I have not tested it for reading STL files.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.

To review the actual code of the crate, it's best to use cargo crev open stl_io. Alternatively, you can download the tarball of stl_io v0.8.5 or view the source online.