0.1.4 (older version) Thoroughness: High Understanding: High
by git.jcg.re/jcgruenhage/crev-proofs.git on 2021-02-15
This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.
The current version of slug is 0.1.5.
These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.
The current version of slug is 0.1.5.
0.1.4 (older version)
From kornelski/crev-proofs copy of salsa.debian.org.
Packaged for Debian (stable). Changelog:
- Package slug 0.1.4 from crates.io using debcargo 2.5.0
0.1.4 (older version)
From kornelski/crev-proofs copy of git.savannah.gnu.org.
Packaged for Guix (crates-io)
cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.
- unknown
-
May have been packaged automatically without a review
- safe-to-run
-
This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.
To review the actual code of the crate, it's best to use cargo crev open slug. Alternatively, you can download the tarball of slug v0.1.5 or view the source online.
Short and concise implementation. A little code that's technically unsafe, for lowercasing ASCII, as Rust's
to_lowercase()impl is slower because it's unicode aware. As it doesn't have to handle unicode where it's used, it is still sound.Aside of it's own code, there is unsafe in the deps too: If
deunicodeis fine, then this is too. I didn't invest enough time indeunicodeto make a final judgement about it, but others have so it's probably okay.