0.1.0 (current) Thoroughness: Medium Understanding: Medium
by dbrgn on 2019-11-26
This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.
Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.
To review the actual code of the crate, it's best to use cargo crev open simple-text-pattern. Alternatively, you can download the tarball of simple-text-pattern v0.1.0 or view the source online.
Overall the code looks clean and easy to understand, with the exception of the is_match / handle_text functions in lib.rs... Those are a bit hard to wrap the head around and could probably be refactored for easier understanding.
Performancewise I have the feeling that a few allocations could be avoided, but I didn't fully think through alternative implementations.