Code review of the Signal crate // Lib.rs

This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of Signal is 0.7.0.

0.6.0 (older version) Rating: Positive Thoroughness: Low Understanding: Low

by dpc on 2019-01-11

Small, but full of low-level unsafe signal handling. LGTM, but it low intensity review.

Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.

To review the actual code of the crate, it's best to use cargo crev open signal. Alternatively, you can download the tarball of signal v0.7.0 or view the source online.