This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of Signal is 0.7.0.

0.6.0 (older version) Rating: Positive Thoroughness: Low Understanding: Low

by dpc on 2019-01-11

Small, but full of low-level unsafe signal handling. LGTM, but it low intensity review.


Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball. To review the actual code of the crate, it's best to use cargo crev open signal. Alternatively, you can download the tarball of signal v0.7.0 or view the source online.