3.1.0 (current)
From kornelski/crev-proofs copy of salsa.debian.org.
These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.
3.1.0 (current)
From kornelski/crev-proofs copy of git.savannah.gnu.org.
Packaged for Guix (crates-io)
cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.
- unknown
-
May have been packaged automatically without a review
These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.
The current version of shellexpand is 3.1.0.
1.0.0 (older version) Thoroughness: Medium Understanding: High
by MaulingMonkey on 2019-09-15
Pros:
- 100% safe code.
- 0 dependencies.
- Does exactly what it's supposed to do.
- Great test coverage.
Cons:
- Might want to feature-gate functions which assume std::env access under the hood.
- Env access (but that's the whole point)
- No ~username/ support.
- No %ENV% support (windows style env var syntax... or maybe that's a feature?).
1.0.0
- Minor breaking changes
- Typo fixes
- Missing example fixes
0.1.0
| File | Rating | Notes |
|---|---|---|
| src/lib.rs | +1 | |
| .cargo-ok | +1 | |
| .gitignore | +1 | |
| .travis.yml | +1 | Installs travis-cargo |
| Cargo.lock | +1 | |
| Cargo.toml | +1 | No 3rd party deps |
| LICENSE-APACHE | +1 | |
| LICENSE-MIT | +1 | |
| Readme.md | +1 | Properly dual licensed |
| Other | Rating | Notes |
|---|---|---|
| unsafe | +1 | None |
| miri | -1 | "can't call foreign function: GetCurrentProcess" |
| fs | +1 | None |
| io | 0 | Hardcoded env fns might need to be featured out for browser WASM targets |
| docs | +1 | |
| tests | +1 | Doc tests |
src/lib.rs
| Line | What | Notes |
|---|---|---|
| 1 | lib.rs doc comments | +1 |
| 155 | fn full_with_context | +1 |
| 229 | fn full_with_context_no_errors | +1 |
| 283 | fn full | +1 |
| 295 | struct LookupError | +1 |
| 303 | impl Display for LookupError | +1 |
| 309 | impl Error for LookupError | +1 |
| 314 | macro_rules try_lookup! | +1 |
| 323 | fn is_valid_var_name_char | +1 - includes unicode, as mentioned in docs |
| 393 | fn env_with_context | +1 |
| 506 | fn env_with_context_no_errors | +1 |
| 552 | fn env | +1 |
| 584 | fn tilde_with_context | 0 - example incomplete |
| 633 | fn tilde | +1 |
| 637 | mod tilde_tets | +1 |
| 675 | mod env_test | +1 |
| 821 | mod full_tests | +1 |
TIL
Apparently you can use references link style for badge images. Huh! I should use that for reviews...
0.1.0 (older version) Thoroughness: Medium Understanding: High
by MaulingMonkey on 2019-09-15
Show review…
Pros:
- 100% safe code.
- 0 dependencies.
- Does exactly what it's supposed to do.
- Great test coverage.
Cons:
- Might want to feature-gate functions which assume std::env access under the hood.
- Env access (but that's the whole point)
- No ~username/ support.
- No %ENV% support (windows style env var syntax... or maybe that's a feature?).
0.1.0
| File | Rating | Notes |
|---|---|---|
| src/lib.rs | +1 | |
| .cargo-ok | +1 | |
| .gitignore | +1 | |
| .travis.yml | +1 | Installs travis-cargo |
| Cargo.lock | +1 | |
| Cargo.toml | +1 | No 3rd party deps |
| LICENSE-APACHE | +1 | |
| LICENSE-MIT | +1 | |
| Readme.md | +1 | Properly dual licensed |
| Other | Rating | Notes |
|---|---|---|
| unsafe | +1 | None |
| miri | -1 | "can't call foreign function: GetCurrentProcess" |
| fs | +1 | None |
| io | 0 | Hardcoded env fns might need to be featured out for browser WASM targets |
| docs | +1 | |
| tests | +1 | Doc tests |
src/lib.rs
| Line | What | Notes |
|---|---|---|
| 1 | lib.rs doc comments | +1 |
| 155 | fn full_with_context | +1 |
| 229 | fn full_with_context_no_errors | +1 |
| 283 | fn full | +1 |
| 295 | struct LookupError | +1 |
| 303 | impl Display for LookupError | +1 |
| 309 | impl Error for LookupError | +1 |
| 314 | macro_rules try_lookup! | +1 |
| 323 | fn is_valid_var_name_char | +1 - includes unicode, as mentioned in docs |
| 393 | fn env_with_context | +1 |
| 506 | fn env_with_context_no_errors | +1 |
| 552 | fn env | +1 |
| 584 | fn tilde_with_context | 0 - example incomplete |
| 633 | fn tilde | +1 |
| 637 | mod tilde_tets | +1 |
| 675 | mod env_test | +1 |
| 821 | mod full_tests | +1 |
TIL
Apparently you can use references link style for badge images. Huh! I should use that for reviews...
Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.
To review the actual code of the crate, it's best to use cargo crev open shellexpand. Alternatively, you can download the tarball of shellexpand v3.1.0 or view the source online.
Only in debcargo (unstable). Changelog: