Code reviews of the safemem crate // Lib.rs

RUSTSEC-2023-0081 (unmaintained) on 2023-02-14: safemem is unmaintained

The latest crates.io release was in 2019. The repository has been archived by the author.

Migration

safemem::copy_over(slice, src_idx, dest_idx, len); can be replaced with slice.copy_within(src_idx..src_idx+len, dest_idx); as of rust 1.37.0.
safemem::write_bytes(slice, byte); can be replaced with slice.fill(byte); as of rust 1.50.0

safemem::prepend(slice, vec); can be replaced with

let old_len = vec.len();
vec.extend_from_slice(slice);
vec.rotate_left(old_len);

as of rust 1.26.0

These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.

0.3.3 (current) safe-to-run

From mozilla/supply-chain copy of hg. By Bobby Holley.

I didn't review the allocation code carefully but it's not malicious.

0.3.3 (current) safe-to-run

From kornelski/crev-proofs copy of salsa.debian.org.

Packaged for Debian (stable). Changelog:

Package safemem 0.3.3 from crates.io using debcargo 2.4.0

0.3.3 (current) unknown

From kornelski/crev-proofs copy of git.savannah.gnu.org.

Packaged for Guix (crates-io)

cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.

safe-to-run

This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…

unknown

May have been packaged automatically without a review

These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of safemem is 0.3.3.

0.3.1 (older version) Rating: Strong Positive Thoroughness: High Understanding: High

Approved without comment by gitlab.com/KonradBorowski on 2019-07-31

0.3.0 (older version) Rating: Negative Thoroughness: High Understanding: High

by gitlab.com/KonradBorowski on 2019-07-30

Show review…

copy_over and prepend functions cause UB

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.

To review the actual code of the crate, it's best to use cargo crev open safemem. Alternatively, you can download the tarball of safemem v0.3.3 or view the source online.