Lib.rs

› RUSTVERSION › Reviews

These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.

The current version of RUSTVERSION is 1.0.18.

1.0.14 (older version) ub-risk-0, safe-to-deploy, does-not-implement-crypto

From google/supply-chain copy of chromium. By Lukasz Anforowicz.

Grepped for -i cipher, -i crypto, 'fs'``, 'net', `'unsafe' and there were no hits except for:

  • Using trivially-safe unsafe in test code:

    tests/test_const.rs:unsafe fn _unsafe() {}
tests/test_const.rs:const _UNSAFE: () = unsafe { _unsafe() };

  • Using unsafe in a string:

    src/constfn.rs:            "unsafe" => Qualifiers::Unsafe,

  • Using std::fs in build/build.rs to write ${OUT_DIR}/version.expr which is later read back via include! used in src/lib.rs.

Version 1.0.6 of this crate has been added to Chromium in https://source.chromium.org/chromium/chromium/src/+/28841c33c77833cc30b286f9ae24c97e7a8f4057

1.0.9 (older version) safe-to-deploy

From mozilla/supply-chain copy of hg. By Bobby Holley.

This crate has a build-time component and procedural macro logic, which I looked at enough to convince myself it wasn't going to do anything dramatically wrong. I don't think logic bugs in the version parsing etc can realistically introduce a security vulnerability.

cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.

safe-to-deploy (implies safe-to-run)

This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…

safe-to-run

This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…

does-not-implement-crypto (implies crypto-safe)

Inspection reveals that the crate in question does not attempt to implement any cryptographic algorithms on its own.

Note that certification of this does not require an expert on all forms of cryptography: it's expected for crates we import to be "good enough" citizens, so they'll at least be forthcoming if they try to implement something cryptographic. When in doubt, please ask an expert.

crypto-safe
Implied by other criteria

All crypto algorithms in this crate have been reviewed by a relevant expert.

Note: If a crate does not implement crypto, use does-not-implement-crypto, which implies crypto-safe, but does not require expert review in order to audit for.

ub-risk-0 (implies ub-risk-1)

No unsafe code.

Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-0

ub-risk-1 (implies ub-risk-2)
Implied by other criteria

Excellent soundness.

Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-1

ub-risk-2 (implies ub-risk-3)

Negligible unsoundness or average soundness.

Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-2

ub-risk-3 (implies ub-risk-4)
Implied by other criteria

Mild unsoundness or suboptimal soundness.

Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-3

ub-risk-4
Implied by other criteria

Extreme unsoundness.

Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-4

unknown

May have been packaged automatically without a review

These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of RUSTVERSION is 1.0.18.

1.0.1 (older version) Rating: Strong Positive Thoroughness: Low Understanding: Medium

by jhpratt on 2020-02-19

This crate makes minimal assumptions about data; the only ones made are ones that will hold true for a significant amount of time. One assumption will not be invalid until the year 2100, while another is that there will not be a Rust 2. The code will likely be updated (or integrated into std) long before either of these become an issue.

Aside from these minimal, relatively safe assumptions, the code looks great.

Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.

To review the actual code of the crate, it's best to use cargo crev open rustversion. Alternatively, you can download the tarball of rustversion v1.0.18 or view the source online.