0.2.0 (older version) Thoroughness: Low Understanding: Low
by MaulingMonkey on 2019-09-03
These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.
The current version of require_unsafe_in_body is 0.3.2.
0.2.0-alpha (older version) Thoroughness: Medium Understanding: Low
by MaulingMonkey on 2019-09-03
Show review…
0.2.0-alpha: Significant refactoring, adding support for generics. LGTM? 0.1.2: Seems solid, although my syn-fu is weak, limiting my ability to review this.
Detail
| File | Rating | Notes |
|---|---|---|
| src/docs/require_unsafe_in_bodies.md | +1 | |
| src/docs/require_unsafe_in_body.md | +1 | |
| src/utils/macros.rs | +1 | |
| src/utils/mod.rs | +1 | |
| src/lib.rs | +1 | understanding: low - I'm barely following along |
| src/tests.rs | +1 | |
| tests/ui/body_on_method_2.rs | +1 | |
| tests/ui/body_on_method_2.stderr | +1 | |
| tests/ui/body_on_method.rs | +1 | |
| tests/ui/body_on_method.stderr | +1 | |
| tests/ui/readme.rs | +1 | |
| tests/ui/readme.stderr | +1 | |
| tests/impl_method_2.rs | +1 | The cfgs on unit-tests look the wrong way around? |
| tests/impl_method.rs | +1 | The cfgs on unit-tests look the wrong way around? |
| tests/trait_default_method.rs | +1 | The cfgs on unit-tests look the wrong way around? |
| tests/ui.rs | +1 | The cfgs on unit-tests look the wrong way around? |
| .cargo_vcs_info.json | +1 | |
| .cargo-ok | +1 | |
| .gitignore | +1 | |
| Cargo.toml | +1 | MIT |
| Cargo.toml.orig | +1 | MIT |
| LICENSE | +1 | MIT |
| Makefile | +1 | Unixy |
| README.md | +1 |
| Other | Rating | Notes |
|---|---|---|
| unsafe | +1 | Wrangles unsafe but doesn't actually use it itself |
| fs | +1 | None |
| io | +1 | Modifies codegen through syn |
| docs | +1 | |
| tests | +1 |
TIL
let Struct { ref member, ref mut member2, .. } = to_destructure;
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.
To review the actual code of the crate, it's best to use cargo crev open require_unsafe_in_body. Alternatively, you can download the tarball of require_unsafe_in_body v0.3.2 or view the source online.
0.2.0: More refactoring surrounding generics. 0.2.0-alpha: Significant refactoring, adding support for generics. LGTM? 0.1.2: Seems solid, although my syn-fu is weak, limiting my ability to review this.
Detail
TIL