Lib.rs

› Regex › Reviews

These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.

The current version of Regex is 1.11.1.

1.10.6 (older version) unknown

From kornelski/crev-proofs copy of salsa.debian.org.

Only in debcargo (unstable). Changelog:

  • Team upload.
  • Package regex 1.10.6 from crates.io using debcargo 2.6.1 (Closes: #1067780, #1069651)
  • Set test_is_broken for the "pattern" feature, it requires nightly rust.

cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.

safe-to-deploy (implies safe-to-run)

This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…

safe-to-run

This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…

does-not-implement-crypto (implies crypto-safe)

Inspection reveals that the crate in question does not attempt to implement any cryptographic algorithms on its own.

Note that certification of this does not require an expert on all forms of cryptography: it's expected for crates we import to be "good enough" citizens, so they'll at least be forthcoming if they try to implement something cryptographic. When in doubt, please ask an expert.

crypto-safe
Implied by other criteria

All crypto algorithms in this crate have been reviewed by a relevant expert.

Note: If a crate does not implement crypto, use does-not-implement-crypto, which implies crypto-safe, but does not require expert review in order to audit for.

unknown

May have been packaged automatically without a review

These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of Regex is 1.11.1.

1.3.1 (older version) Rating: Positive Thoroughness: Low Understanding: Medium

Approved without comment by gitlab.com/KonradBorowski on 2019-10-02

1.2.1 (older version) Rating: Positive Thoroughness: High Understanding: High

by BurntSushi on 2019-08-23

I wrote this crate, so this review is a reflection as a result of writing the code and then reviewing it again for this review.

I gave a rating of positive because the implementation in the regex crate has remain mostly unchanged for a long period of time, so it has matured and been battle tested. Moreover, the crate uses very little unsafe directly. The only uses are in the DFA regex engine for explicitly eliding bounds checks in very hot loops.

A better rating is likely deserved, but there are still a few outstanding bugs that can produce incorrect matches. In many cases, these bugs are a result of optimizations using literal searches, which can be subtle and difficult to get right.

Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.

To review the actual code of the crate, it's best to use cargo crev open regex. Alternatively, you can download the tarball of regex v1.11.1 or view the source online.