These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.

The current version of regex_syntax is 0.8.3.

cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.

safe-to-run

This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…

does-not-implement-crypto (implies crypto-safe)

Inspection reveals that the crate in question does not attempt to implement any cryptographic algorithms on its own.

Note that certification of this does not require an expert on all forms of cryptography: it's expected for crates we import to be "good enough" citizens, so they'll at least be forthcoming if they try to implement something cryptographic. When in doubt, please ask an expert.

crypto-safe
Implied by other criteria

All crypto algorithms in this crate have been reviewed by a relevant expert.

Note: If a crate does not implement crypto, use does-not-implement-crypto, which implies crypto-safe, but does not require expert review in order to audit for.

safe-to-deploy (implies safe-to-run)

This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…

unknown

May have been packaged automatically without a review


This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of regex_syntax is 0.8.3.

0.6.11 (older version) Rating: Strong Positive Thoroughness: High Understanding: High

by BurntSushi on 2019-08-22

I wrote this crate, so this review is a reflection as a result of writing the code and then reviewing it again for this review.

The regex-syntax crate is mostly an internal implementation detail of the regex crate. It is exposed as a stand-alone crate for the occasional use case where it is convenient to analyze the syntax of a regex. The primary thing that the regex-syntax crate provides is a parser for the concrete syntax supported by the regex crate.

The regex-syntax crate is very large, but there is no unsafe used anywhere. Moreover, it has no dependencies. That means that no matter what concrete syntax is given, the worst that can happen is a panic. Memory safety should be preserved (modulo bugs in the compiler or the standard library). On top of that, the parser does not use explicit recursion and enforces a nest depth by default, so it should generally be safe with respect to arbitrary input.


Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball. To review the actual code of the crate, it's best to use cargo crev open regex-syntax. Alternatively, you can download the tarball of regex-syntax v0.8.3 or view the source online.