0.7.0 (current)
From zcash/rust-ecosystem copy of zcash/zcash. By Daira Emma Hopwood.
This review is from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.
cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.
- safe-to-deploy (implies safe-to-run)
-
This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…
- safe-to-run
Implied by other criteria
This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…
- crypto-reviewed
-
The cryptographic code in this crate has been reviewed for correctness by a member of a designated set of cryptography experts within the project.
Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.
To review the actual code of the crate, it's best to use cargo crev open redjubjub. Alternatively, you can download the tarball of redjubjub v0.7.0 or view the source online.
This crate is a thin wrapper around the
reddsacrate, which I did not review. I also did not review tests or verify test vectors.The comment on
batch::Verifier::verifyhas an error in the batch verification equation, filed as https://github.com/ZcashFoundation/redjubjub/issues/163 . It does not affect the implementation which just delegates toreddsa.reddsahas the same comment bug filed as https://github.com/ZcashFoundation/reddsa/issues/52 , but its batch verification implementation is correct. (I checked the latter against https://zips.z.cash/protocol/protocol.pdf#reddsabatchvalidate which has had previous cryptographic review by NCC group; see finding NCC-Zcash2018-009 in https://research.nccgroup.com/wp-content/uploads/2020/07/NCC_Group_Zcash2018_Public_Report_2019-01-30_v1.3.pdf ).