Code review of the ReadWriteAt crate // Lib.rs

This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

0.1.0 (current) Rating: Positive Thoroughness: High Understanding: High

by MaulingMonkey on 2020-09-11

Offset read/write with &self

Pros:

No runtime dependencies
Very thorough, well documented

Cons:

File isn't ReadAt/WriteAt on windows due to seeks... reasonable but annoying
A couple of minor API holes to be fixed

Full Audit

Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.

To review the actual code of the crate, it's best to use cargo crev open read_write_at. Alternatively, you can download the tarball of read_write_at v0.1.0 or view the source online.