Lib.rs

› pretty_assertions › Reviews

This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

1.4.0 (current) Rating: Positive Thoroughness: Medium Understanding: Medium

by kpreid on 2023-07-14

Simple, clear code. No unsafe.

I have some nitpicks about correctness-in-all-cases but none of them would do significant harm if not addressed. Specifically:

  • The macros have internal-use arms, which could instead be implemented as separate macros.
  • The package defines mutually exclusive Cargo features, which is incorrect (https://doc.rust-lang.org/cargo/reference/features.html#feature-unification); if a std-using package depends on a no_std package and both of them depend on pretty_assertions then both features will end up enabled.

This review is from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.

cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.

unknown

May have been packaged automatically without a review

Lib.rs has been able to verify that all files in the crate's tarball, except Cargo.lock, are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.

To review the actual code of the crate, it's best to use cargo crev open pretty_assertions. Alternatively, you can download the tarball of pretty_assertions v1.4.0 or view the source online.