Code review of the piston-music crate // Lib.rs

This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of piston-music is 0.26.0.

0.25.1 (older version) Rating: Negative Thoroughness: Medium Understanding: Medium

by git.sr.ht/~icefox on 2019-08-30

Gratiutous unsafe and global mutable state where there doesn't need to be any.

Lib.rs has been able to verify that all files in the crate's tarball, except Cargo.lock, are in the crate's repository. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.

To review the actual code of the crate, it's best to use cargo crev open piston-music. Alternatively, you can download the tarball of piston-music v0.26.0 or view the source online.