0.2.14 (older version) Thoroughness: Medium Understanding: Medium
by kaiserkarel on 2022-01-17
These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.
The current version of num-traits is 0.2.15.
0.2.14 (older version) Thoroughness: None Understanding: Low
by inflation on 2021-11-08
Used by almost everyone
0.2.11 (older version) Thoroughness: Medium Understanding: High
by HeroicKatora on 2020-04-29
With a prior parsing bug fixed and Rust soon stabilizing floating point to integer conversion without UB the previous reservations no longer hold. It looks stable as is and doesn't attempt anything far fetched.
0.2.11 (older version) Thoroughness: None Understanding: High
by niklasf on 2020-01-18
num-traits provides traits for writing code generic over numeric types and implementations for built-in numeric types. I exclusively reviewed unsafe code.
num-traits uses some instances of unsafe code. Each unsafe block has a comment explaining why it is required and why it is sound. The blocks are easy to understand and check locally.
0.2.9 (older version) Thoroughness: None Understanding: None
by HeroicKatora on 2020-04-29
Show review…
Fixed panic when parsing floating point literals
-
Issue: Medium (github.com/rust-num/num-traits/issues/125)
Potential denial of service, panic
0.2.8 (older version) Thoroughness: Medium Understanding: Medium
by git.sr.ht/~icefox on 2019-08-23
Mostly just traits; unsafe can probably be removed, see https://github.com/rust-num/num-traits/issues/123
0.2.6 (older version) Thoroughness: Medium Understanding: High
by HeroicKatora on 2019-08-30
Show review…
Not quite ready for untrusted input due to panics and not fuzzed. Minor
soundness concerns for floating point operations, rooted in Rust language
as operator not having fully specified behaviour (yet). All is well for the
integer part of the library.
-
Issue: Medium (github.com/rust-num/num-traits/issues/125)
0.2.6 (older version) Thoroughness: Low Understanding: Low
Approved without comment by Canop on 2019-07-05
0.1.43 (older version) Thoroughness: Medium Understanding: Medium
by git.sr.ht/~icefox on 2019-08-23
Show review…
Nothing but a re-export of num-traits 0.2
No backdoors etc found, mainly looked at risks for supply-chain attacks.