0.2.14 (older version) Thoroughness: Medium Understanding: Medium
by kaiserkarel on 2022-01-17
These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev
.
The current version of num-traits is 0.2.16.
0.2.14 (older version) Thoroughness: Medium Understanding: Medium
by kaiserkarel on 2022-01-17
0.2.14 (older version) Thoroughness: None Understanding: Low
by inflation on 2021-11-08
Used by almost everyone
0.2.11 (older version) Thoroughness: Medium Understanding: High
by HeroicKatora on 2020-04-29
With a prior parsing bug fixed and Rust soon stabilizing floating point to integer conversion without UB the previous reservations no longer hold. It looks stable as is and doesn't attempt anything far fetched.
0.2.11 (older version) Thoroughness: None Understanding: High
by niklasf on 2020-01-18
num-traits provides traits for writing code generic over numeric types and implementations for built-in numeric types. I exclusively reviewed unsafe code.
num-traits uses some instances of unsafe code. Each unsafe block has a comment explaining why it is required and why it is sound. The blocks are easy to understand and check locally.
0.2.9 (older version) Thoroughness: None Understanding: None
by HeroicKatora on 2020-04-29
Fixed panic when parsing floating point literals
Issue: Medium (github.com/rust-num/num-traits/issues/125)
Potential denial of service, panic
0.2.8 (older version) Thoroughness: Medium Understanding: Medium
by git.sr.ht/~icefox on 2019-08-23
Mostly just traits; unsafe can probably be removed, see https://github.com/rust-num/num-traits/issues/123
0.2.6 (older version) Thoroughness: Medium Understanding: High
by HeroicKatora on 2019-08-30
Not quite ready for untrusted input due to panics and not fuzzed. Minor
soundness concerns for floating point operations, rooted in Rust language
as
operator not having fully specified behaviour (yet). All is well for the
integer part of the library.
Issue: Medium (github.com/rust-num/num-traits/issues/125)
0.2.6 (older version) Thoroughness: Low Understanding: Low
Approved without comment by Canop on 2019-07-05
0.1.43 (older version) Thoroughness: Medium Understanding: Medium
by git.sr.ht/~icefox on 2019-08-23
Nothing but a re-export of num-traits 0.2
These reviews are from cargo-vet. To add your review, set up cargo-vet
and submit your URL to its registry.
0.2.16 — diff review from 0.2.15 only (current)
From google/supply-chain copy of chromium. Audited without comment by George Burgess IV.
0.2.16 — diff review from 0.2.15 only (current)
From divviup/libprio-rs. Audited without comment by David Cook.
The current version of num-traits is 0.2.16.
0.2.15 (older version)
From google/supply-chain copy of chromium. Audited without comment by George Burgess IV.
0.2.15 (older version)
From mozilla/supply-chain copy of hg. By Josh Stone.
All code written or reviewed by Josh Stone.
0.2.14 (older version)
From google/supply-chain copy of chromium. Audited without comment by Android Legacy.
This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…
Inspection reveals that the crate in question does not attempt to implement any cryptographic algorithms on its own.
Note that certification of this does not require an expert on all forms of cryptography: it's expected for crates we import to be "good enough" citizens, so they'll at least be forthcoming if they try to implement something cryptographic. When in doubt, please ask an expert.
All crypto algorithms in this crate have been reviewed by a relevant expert.
Note: If a crate does not implement crypto, use does-not-implement-crypto
,
which implies crypto-safe
, but does not require expert review in order to
audit for.
This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…
cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.
To review the actual code of the crate, it's best to use cargo crev open num-traits
. Alternatively, you can download the tarball of num-traits v0.2.16 or view the source online.
No backdoors etc found, mainly looked at risks for supply-chain attacks.