Lib.rs

› num-traits › Reviews

These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of num-traits is 0.2.16.

0.2.14 (older version) Rating: Positive Thoroughness: Medium Understanding: Medium

by kaiserkarel on 2022-01-17

No backdoors etc found, mainly looked at risks for supply-chain attacks.

0.2.14 (older version) Rating: Neutral Thoroughness: None Understanding: Low

by inflation on 2021-11-08

Used by almost everyone

0.2.11 (older version) Rating: Positive Thoroughness: Medium Understanding: High

by HeroicKatora on 2020-04-29

With a prior parsing bug fixed and Rust soon stabilizing floating point to integer conversion without UB the previous reservations no longer hold. It looks stable as is and doesn't attempt anything far fetched.

0.2.11 (older version) Rating: Positive Thoroughness: None Understanding: High

by niklasf on 2020-01-18

num-traits provides traits for writing code generic over numeric types and implementations for built-in numeric types. I exclusively reviewed unsafe code.

num-traits uses some instances of unsafe code. Each unsafe block has a comment explaining why it is required and why it is sound. The blocks are easy to understand and check locally.

0.2.9 (older version) Rating: Neutral Thoroughness: None Understanding: None

by HeroicKatora on 2020-04-29

Show review…

Fixed panic when parsing floating point literals

0.2.6 (older version) Rating: Positive Thoroughness: Medium Understanding: High

by HeroicKatora on 2019-08-30

Show review…

Not quite ready for untrusted input due to panics and not fuzzed. Minor soundness concerns for floating point operations, rooted in Rust language as operator not having fully specified behaviour (yet). All is well for the integer part of the library.

0.2.6 (older version) Rating: Positive Thoroughness: Low Understanding: Low

Approved without comment by Canop on 2019-07-05

0.1.43 (older version) Rating: Positive Thoroughness: Medium Understanding: Medium

by git.sr.ht/~icefox on 2019-08-23

Show review…

Nothing but a re-export of num-traits 0.2

These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.

The current version of num-traits is 0.2.16.

safe-to-run

This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…

does-not-implement-crypto (implies crypto-safe)

Inspection reveals that the crate in question does not attempt to implement any cryptographic algorithms on its own.

Note that certification of this does not require an expert on all forms of cryptography: it's expected for crates we import to be "good enough" citizens, so they'll at least be forthcoming if they try to implement something cryptographic. When in doubt, please ask an expert.

crypto-safe
Implied by other criteria

All crypto algorithms in this crate have been reviewed by a relevant expert.

Note: If a crate does not implement crypto, use does-not-implement-crypto, which implies crypto-safe, but does not require expert review in order to audit for.

safe-to-deploy (implies safe-to-run)

This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…

cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball. To review the actual code of the crate, it's best to use cargo crev open num-traits. Alternatively, you can download the tarball of num-traits v0.2.16 or view the source online.