Lib.rs

› Non-max › Reviews

These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of Non-max is 0.5.5.

0.4.0 (older version) Rating: Positive Thoroughness: High Understanding: High

by MaulingMonkey on 2020-10-11

[Full Audit] std::num::NonZero___ equivalents

Pros:

  • Works
  • Can represent 0
  • Clever cheap xors for implementation

Cons:

  • Missing a lot of traits vs equivalent NonZero*s
  • Extra pointless unsafe in new impl

0.3.0 (older version) Rating: Positive Thoroughness: High Understanding: High

by MaulingMonkey on 2020-10-11

Show review…

[Full Audit] std::num::NonZero___ equivalents

Pros:

  • Works
  • Can represent 0
  • Clever cheap xors for implementation

Cons:

  • Missing a lot of traits vs equivalent NonZero*s
  • Extra pointless unsafe in new impl

Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.

To review the actual code of the crate, it's best to use cargo crev open nonmax. Alternatively, you can download the tarball of nonmax v0.5.5 or view the source online.