Code review of the median_three_quicksort crate // Lib.rs

This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

0.0.1 (current) Rating: Negative Thoroughness: Low Understanding: Medium

by gitlab.com/KonradBorowski on 2022-02-12

crater has the following line in its code

median_three_quicksort = { skip-tests = true } # sorting library that sometimes doesn't sort (WTF)

I think that says enough. This crate doesn't work as it should - there is probably some bug in an implementation.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.

To review the actual code of the crate, it's best to use cargo crev open median_three_quicksort. Alternatively, you can download the tarball of median_three_quicksort v0.0.1 or view the source online.