0.2.0 (older version) Thoroughness: Medium Understanding: Medium
by MTRNord on 2021-02-01
This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev
.
The current version of matrix-sdk is 0.6.2.
0.2.0 (older version) Thoroughness: Medium Understanding: Medium
by MTRNord on 2021-02-01
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.
To review the actual code of the crate, it's best to use cargo crev open matrix-sdk
. Alternatively, you can download the tarball of matrix-sdk v0.6.2 or view the source online.
=Review Matrix-SDK=
==Cargo audit==
==Cargo clippy==
All green
==Cargo test==
All green
==Code==