Code review of the matrix-sdk crate // Lib.rs

This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of matrix-sdk is 0.11.0.

0.2.0 (older version) Rating: Positive Thoroughness: Medium Understanding: Medium

by MTRNord on 2021-02-01

=Review Matrix-SDK=

==Cargo audit==

Dependency affected by smallvec bug https://rustsec.org/advisories/RUSTSEC-2021-0003
Mockito dependency uses unmaintained crate "difference"
Directly uses unmaintained "dirs" crate
Through a deep chain of deps uses "net2" which is unmaintained
Indirectly uses "stdweb"

==Cargo clippy==

All green

==Cargo test==

All green

==Code==

Lots of well documentation
Easy to reach community channel to ask questions
Many tests which all are green
Multiple good documented examples

Lib.rs has been able to verify that all files in the crate's tarball, except Cargo.lock, are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.

To review the actual code of the crate, it's best to use cargo crev open matrix-sdk. Alternatively, you can download the tarball of matrix-sdk v0.11.0 or view the source online.