0.1.1 (current) Thoroughness: Medium Understanding: Medium
by fishi0x01 on 2020-03-13
This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev
.
0.1.1 (current) Thoroughness: Medium Understanding: Medium
by fishi0x01 on 2020-03-13
Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.
To review the actual code of the crate, it's best to use cargo crev open libdb
. Alternatively, you can download the tarball of libdb v0.1.1 or view the source online.
I am the maintainer of libdb. libdb is an idiomatic rust wrapper for Berkeley DB. It uses unsafe ffi methods from libdb-sys.
The underlying code was forked from Jesse Morgan, who allowed me to modify it and publish it to crates.io. I do not fully understand every aspect of Jesse Morgan's original code and I mainly added new features. That is why I can only rate this with a medium understanding value.
As this crate is an idiomatic wrapper by design it contains a lot of unsafe calls to external ffi methods. However, as I also maintain and trust libdb-sys, I can give this crate an overall positive rating.