1.4.0 (current) Thoroughness: High Understanding: High
by MaulingMonkey on 2019-09-03
These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.
1.4.0 (current) Thoroughness: Medium Understanding: High
by HeroicKatora on 2019-08-30
A bit puzzling that the inline implementation does not use UnsafeCell
directly but only through Cell. This adds a Sync impl which explicitely can
not exist for Cell itself. But the Once is enough to protect against races
even though there is no real benefit from using Cell over UnsafeCell.
1.4.0 (current) Thoroughness: Medium Understanding: High
by BurntSushi on 2019-08-28
The 1.4.0 release removes the hand-rolled unreachable hint in favor of
unreachable_unchecked, which was a new API introduced in Rust 1.27.
Otherwise, nothing substantial was changed, other than allowing some
deprecated APIs to support older versions of Rust.
The current version of LazyStatic is 1.4.0.
1.3.0 (older version) Thoroughness: Low Understanding: Medium
Approved without comment by git.sr.ht/~icefox on 2019-08-20
1.3.0 (older version) Thoroughness: High Understanding: High
by MaulingMonkey on 2019-07-23
Show review…
Read all of src, skimmed all of tests. core_lazy.rs looks a little odd, but is 100% safe code - any issues would be in it's core dependency, spin. inline_lazy.rs contains unsafe blocks... look safe, but downgrades rating to merely positive. lib.rs is just safe macros. Tests all pass.
1.3.0 (older version) Thoroughness: Low Understanding: Medium
by Canop on 2019-06-21
It looks OK... it's a little hard to check all the possible ways such a code could be flawed, though.
1.2.0 (older version) Thoroughness: Medium Understanding: Medium
Approved without comment by dpc on 2018-12-20
These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.
1.4.0 (current)
From google/supply-chain copy of chromium. Audited without comment by Android Legacy.
1.4.0 (current)
From google/supply-chain copy of chromium. By Lukasz Anforowicz.
I grepped for "crypt", "cipher", "fs", "net" - there were no hits.
There are two places where unsafe is used. Unsafe review notes can be found
in https://crrev.com/c/5347418.
This crate has been added to Chromium in https://crrev.com/c/3321895.
1.4.0 (current)
From mozilla/supply-chain copy of mozilla/cargo-vet. By Nika Layzell.
I have read over the macros, and audited the unsafe code.
1.4.0 (current)
From kornelski/crev-proofs copy of git.savannah.gnu.org.
Packaged for Guix (crates-io)
cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.
- safe-to-run
-
This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…
- safe-to-deploy (implies safe-to-run)
-
This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…
- does-not-implement-crypto (implies crypto-safe)
-
Inspection reveals that the crate in question does not attempt to implement any cryptographic algorithms on its own.
Note that certification of this does not require an expert on all forms of cryptography: it's expected for crates we import to be "good enough" citizens, so they'll at least be forthcoming if they try to implement something cryptographic. When in doubt, please ask an expert.
- crypto-safe
Implied by other criteria
All crypto algorithms in this crate have been reviewed by a relevant expert.
Note: If a crate does not implement crypto, use
does-not-implement-crypto, which impliescrypto-safe, but does not require expert review in order to audit for.- ub-risk-2 (implies ub-risk-3)
-
Negligible unsoundness or average soundness.
Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-2
- ub-risk-3 (implies ub-risk-4)
Implied by other criteria
Mild unsoundness or suboptimal soundness.
Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-3
- ub-risk-4
Implied by other criteria
Extreme unsoundness.
Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-4
- unknown
-
May have been packaged automatically without a review
Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.
To review the actual code of the crate, it's best to use cargo crev open lazy_static. Alternatively, you can download the tarball of lazy_static v1.4.0 or view the source online.
1.4.0: Read diff, looks fine. 1.3.0: Read all of src, skimmed all of tests. core_lazy.rs looks a little odd, but is 100% safe code - any issues would be in it's core dependency, spin. inline_lazy.rs contains unsafe blocks... look safe, but downgrades rating to merely positive. lib.rs is just safe macros. Tests all pass.