0.21.3 (older version)
From kornelski/crev-proofs copy of salsa.debian.org.
These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.
The current version of gettext-sys is 0.22.5.
0.21.0 (older version)
From kornelski/crev-proofs copy of git.savannah.gnu.org.
Packaged for Guix (crates-io)
cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.
- safe-to-run
-
This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…
- unknown
-
May have been packaged automatically without a review
These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.
The current version of gettext-sys is 0.22.5.
0.21.0 (older version) Thoroughness: High Understanding: High
by Minoru on 2021-03-03
This is basically a self-review, since it's me who fixed the problems I highlighted in my previous review.
The crate now bundles an up-to-date version of GNU gettext, which is nice.
The documentation now features a prominent warning about the bundled library's license, LGPL.
This release added one new binding and some workarounds for build issues. All of that looks good to me (but remember that I'm the author of those changes).
The crate is now even more solid than before.
0.19.9 (older version) Thoroughness: Medium Understanding: High
by Minoru on 2021-02-15
Show review…
This crate bundles an older version of GNU gettext and provides unsafe FFI bindings.
I checked, and bindings indeed correspond to the contents of the C headers libintl.h and locale.h.
The only complex part of this crate is a build script, but it mostly deals with platform differences. There are a few FIXMEs, but they're all benign.
The bundled library is licensed under LGPL, which puts some restrictions on how it can be used. The crate's documentation currently doesn't make this clear though: https://github.com/Koka/gettext-rs/issues/31
Giving a strong rating because code-wise, this is a solid crate, and licensing issues don't change that.
Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.
To review the actual code of the crate, it's best to use cargo crev open gettext-sys. Alternatively, you can download the tarball of gettext-sys v0.22.5 or view the source online.
Packaged for Debian (stable). Changelog: