0.7.0 (older version) Thoroughness: High Understanding: High
by Minoru on 2021-04-26
These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev
.
The current version of gettext-rs is 0.7.2.
0.7.0 (older version) Thoroughness: High Understanding: High
by Minoru on 2021-04-26
0.6.0 (older version) Thoroughness: High Understanding: High
by Minoru on 2021-03-03
This is basically a self-review, since it's me who fixed the problems I highlighted in my previous review.
This crate contains safe FFI bindings for gettext.
The memory issues I mentioned in the previous review are fixed, and panics
documented. There are no unwrap
s, and all errors are propagated via
Result
s.
The crate still depends on gettext returning UTF-8, but this is now prominently documented.
Compared to 0.5.0, the API is more fleshed out and polished (even if I say so myself).
These reviews are from cargo-vet. To add your review, set up cargo-vet
and submit your URL to its registry.
The current version of gettext-rs is 0.7.2.
0.7.0 (older version)
From kornelski/crev-proofs copy of salsa.debian.org.
Packaged for Debian (stable). Changelog:
[ Alexander Kjäll ]
0.7.0 (older version)
From kornelski/crev-proofs copy of git.savannah.gnu.org.
Packaged for Guix (crates-io)
cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.
May have been packaged automatically without a review
This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…
Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.
To review the actual code of the crate, it's best to use cargo crev open gettext-rs
. Alternatively, you can download the tarball of gettext-rs v0.7.2 or view the source online.
This is a self-review, because this release is made by me and contains only the changes that I made.
The crate provides safe wrappers over an FFI for GNU gettext (which is packaged separately, as a gettext-sys crate). There are no known issues with those wrappers.
This release fixes an incorrect default for XDG_DATA_DIRS. There are no security implications to this change, as far as I can see.