0.1.16 (older version) Thoroughness: Low Understanding: High
by niklasf on 2021-02-24
These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.
The current version of gaviota-sys is 0.1.27.
0.1.12 (older version) Thoroughness: Low Understanding: High
by niklasf on 2020-02-27
Show review…
As the author of these bindings, I would not trust the underlying C library to handle malicious input. Verify the checksums of tablebase files! This is a good idea anyway.
Assuming that is done, I am quite confident in the corectness of the probing results, based on years of production usage and comparison with Syzygy tablebases.
Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.
To review the actual code of the crate, it's best to use cargo crev open gaviota-sys. Alternatively, you can download the tarball of gaviota-sys v0.1.27 or view the source online.
As the author of these bindings, I would not trust the underlying C library to handle malicious input. Verify the checksums of tablebase files! This is a good idea anyway.
Assuming that is done, I am quite confident in the corectness of the probing results, based on years of production usage and comparison with Syzygy tablebases.