Code review of the Froggy crate // Lib.rs

This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

0.4.4 (current) Rating: Negative Thoroughness: None Understanding: None

by MaulingMonkey on 2019-09-27

Yet another unsound ECS. Saw more 16-bit counters too.

Issue: High (github.com/kvark/froggy/issues/72)

Unsound API due to debug-only bounds checks

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.

To review the actual code of the crate, it's best to use cargo crev open froggy. Alternatively, you can download the tarball of froggy v0.4.4 or view the source online.