1.2.1 (current)
From mozilla/supply-chain copy of hg. Audited without comment by Valentin Gosu.
These reviews are from cargo-vet. To add your review, set up cargo-vet
and submit your URL to its registry.
1.2.1 (current)
From mozilla/supply-chain copy of hg. Audited without comment by Valentin Gosu.
1.2.1 (current)
From kornelski/crev-proofs copy of git.savannah.gnu.org.
The current version of form_urlencoded is 1.2.1.
1.2.0 — diff review from 1.1.0 only (older version)
From google/supply-chain copy of chromium. Audited without comment by George Burgess IV.
1.1.0 (older version)
From bytecodealliance/wasmtime. By Alex Crichton.
This is a small crate for working with url-encoded forms which doesn't have any
more than what it says on the tin. Contains one unsafe
block related to
performance around utf-8 validation which is fairly easy to verify as correct.
cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.
This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…
This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…
Inspection reveals that the crate in question does not attempt to implement any cryptographic algorithms on its own.
Note that certification of this does not require an expert on all forms of cryptography: it's expected for crates we import to be "good enough" citizens, so they'll at least be forthcoming if they try to implement something cryptographic. When in doubt, please ask an expert.
All crypto algorithms in this crate have been reviewed by a relevant expert.
Note: If a crate does not implement crypto, use does-not-implement-crypto
,
which implies crypto-safe
, but does not require expert review in order to
audit for.
May have been packaged automatically without a review
This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev
.
The current version of form_urlencoded is 1.2.1.
1.0.1 (older version) Thoroughness: Medium Understanding: Low
by Minoru on 2021-05-01
The crate encodes and decodes parameters of web forms.
I verified that the decoding algorithm matches the spec. The encoding is more involved, so I didn't verify that. Notably, the crate has no tests, so I only trust to it be correct because it's written by the Servo team.
There are two uses of unsafe
, for performance (avoiding UTF-8 checks). Both
have comments explaining why they're okay, and they sound convincing enough.
Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.
To review the actual code of the crate, it's best to use cargo crev open form_urlencoded
. Alternatively, you can download the tarball of form_urlencoded v1.2.1 or view the source online.
Packaged for Guix (crates-io)