Lib.rs

› foreign-types › Reviews

These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of foreign-types is 0.5.0.

0.4.0 (older version) Rating: Positive Thoroughness: None Understanding: None

by dpc on 2019-10-04

Looks sane, but I'm not familiar with it.

0.3.2 (older version) Rating: Positive Thoroughness: Low Understanding: Medium

by kotauskas on 2020-04-05

The issue reported before related to unsafety hiding has been resolved by the author. As such, the crate can now be considered fully sound.

0.3.2 (older version) Rating: Negative Thoroughness: Medium Understanding: Medium

by MaulingMonkey on 2019-07-27

Show review…

foreign_type! can generate unsound code without using the unsafe keyword in client code at all.

  • Invokes C FFI which may be unsafe from safe fns.
  • More recent versions (0.4.0) can implement unsafe traits (Send, Sync) without the unsafe keyword at all.

These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.

The current version of foreign-types is 0.5.0.

0.3.2 (older version) safe-to-deploy

From bytecodealliance/wasmtime. By Pat Hickey.

This crate defined a macro-rules which creates wrappers working with FFI types. The implementation of this crate appears to be safe, but each use of this macro would need to be vetted for correctness as well.

cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.

safe-to-deploy (implies safe-to-run)

This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…

safe-to-run

This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…

does-not-implement-crypto (implies crypto-safe)

Inspection reveals that the crate in question does not attempt to implement any cryptographic algorithms on its own.

Note that certification of this does not require an expert on all forms of cryptography: it's expected for crates we import to be "good enough" citizens, so they'll at least be forthcoming if they try to implement something cryptographic. When in doubt, please ask an expert.

crypto-safe
Implied by other criteria

All crypto algorithms in this crate have been reviewed by a relevant expert.

Note: If a crate does not implement crypto, use does-not-implement-crypto, which implies crypto-safe, but does not require expert review in order to audit for.

unknown

May have been packaged automatically without a review

Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.

To review the actual code of the crate, it's best to use cargo crev open foreign-types. Alternatively, you can download the tarball of foreign-types v0.5.0 or view the source online.