Code reviews of the FNV crate // Lib.rs

These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

1.0.7 (current) Rating: Positive Thoroughness: Low Understanding: Medium

by leo60228 on 2021-09-28

changes imports for no_std, no changes to code

1.0.7 (current) Rating: Strong Positive Thoroughness: High Understanding: High

by Minoru on 2021-04-28

FNV is an extremely simple hashing algorithm. This crate implements a variant called FNV-1a.

It uses no unsafe, and just basic arithmetic. Half the code is actually tests. I'm convinced that there are no bugs here, and definitely no malicious code.

The current version of FNV is 1.0.7.

1.0.6 (older version) Rating: Positive Thoroughness: Medium Understanding: Medium

by git.sr.ht/~icefox on 2019-09-19

Turns out the FNV algorithm is clever but trivial to implement, and this crate does nothing besides implement it.

These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.

1.0.7 (current) safe-to-run, does-not-implement-crypto

From google/supply-chain copy of chromium. By George Burgess IV.

fnv explicitly documents that it does not attempt to be crypto-secure, nor does it try to guard against collisions. Hence, this does not implement crypto.

1.0.7 (current) safe-to-deploy

From mozilla/supply-chain copy of hg. By Bobby Holley.

Simple hasher implementation with no unsafe code.

1.0.7 (current) safe-to-run

From kornelski/crev-proofs copy of salsa.debian.org.

Packaged for Debian (stable). Changelog:

Team upload.
Package fnv 1.0.7 from crates.io using debcargo 2.5.0

[ Wolfgang Silbermayr ]

Package fnv 1.0.7 from crates.io using debcargo 2.4.4-alpha.0

1.0.7 (current) unknown

From kornelski/crev-proofs copy of git.savannah.gnu.org.

Packaged for Guix (crates-io)

cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.

safe-to-run

This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…

does-not-implement-crypto (implies crypto-safe)

Inspection reveals that the crate in question does not attempt to implement any cryptographic algorithms on its own.

Note that certification of this does not require an expert on all forms of cryptography: it's expected for crates we import to be "good enough" citizens, so they'll at least be forthcoming if they try to implement something cryptographic. When in doubt, please ask an expert.

crypto-safe

Implied by other criteria

All crypto algorithms in this crate have been reviewed by a relevant expert.

Note: If a crate does not implement crypto, use does-not-implement-crypto, which implies crypto-safe, but does not require expert review in order to audit for.

safe-to-deploy (implies safe-to-run)

This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…

unknown

May have been packaged automatically without a review

Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.

To review the actual code of the crate, it's best to use cargo crev open fnv. Alternatively, you can download the tarball of fnv v1.0.7 or view the source online.