Code reviews of the dirs-sys crate // Lib.rs

These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.

0.5.0 — diff review from 0.4.1 only (current) safe-to-deploy

From zcash/rust-ecosystem copy of zcash/librustzcash. By Jack Grigg.

One change to an unsafe block, adapting to an API change in windows_sys (Win32::Foundation::HANDLE changed from isize to *mut c_void). I confirmed that the Windows documentation permits an argument of std::ptr::null_mut().

The current version of dirs-sys is 0.5.0.

0.4.1 (older version) unknown

From kornelski/crev-proofs copy of salsa.debian.org.

Only in debcargo (unstable). Changelog:

Package dirs-sys 0.4.1 from crates.io using debcargo 2.6.0

0.4.1 (older version) unknown

From kornelski/crev-proofs copy of git.savannah.gnu.org.

Packaged for Guix (crates-io)

0.4.0 — diff review from 0.3.7 only (older version) safe-to-deploy

From zcash/rust-ecosystem copy of zcash/zcash. By Jack Grigg.

Changes to unsafe code are migrating from winapi to windows-sys. The APIs are equivalent, with the windows-sys ones being slightly more type-safe.

cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.

safe-to-deploy (implies safe-to-run)

This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…

safe-to-run

Implied by other criteria

This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…

unknown

May have been packaged automatically without a review

These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of dirs-sys is 0.5.0.

0.3.4 (older version) Rating: Neutral Thoroughness: None Understanding: None

by Minoru on 2020-06-27

Overwriting my earlier review: this crate is maintained, development moved to https://github.com/dirs-dev

0.3.4 (older version) Rating: Positive Thoroughness: Medium Understanding: High

Approved without comment by kpcyrd on 2019-08-30

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.

To review the actual code of the crate, it's best to use cargo crev open dirs-sys. Alternatively, you can download the tarball of dirs-sys v0.5.0 or view the source online.