Lib.rs

› dinghy-build › Reviews

These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of dinghy-build is 0.7.3.

0.4.16 (older version) Rating: Positive Thoroughness: Medium Understanding: Low

by MaulingMonkey on 2019-09-17

0.4.16: Trivial version bumps. 0.4.15: Trivial version bumps. 0.4.14: Trivial version bumps, style changes. 0.4.13: Trivial version bumps. 0.4.12: Trivial version bumps. 0.4.11 Some of the build/path stuff seems a little off... but might be correct? All safe code, no security problems.

Reviewed:

src\build_env.rs    +1
src\build.rs        +1
src\lib.rs          0
    102 Is this really correct for specifying the *host* environment?
    105 ..
src\utils.rs        0
    14  Isn't this generating /../../../ ?  Doesn't seem right...

Cargo.toml          +1
Cargo.toml.orig     +1

0.4.15 (older version) Rating: Positive Thoroughness: Medium Understanding: Low

by MaulingMonkey on 2019-09-17

Show review…

0.4.15: Trivial version bumps. 0.4.14: Trivial version bumps, style changes. 0.4.13: Trivial version bumps. 0.4.12: Trivial version bumps. 0.4.11 Some of the build/path stuff seems a little off... but might be correct? All safe code, no security problems.

Reviewed:

src\build_env.rs    +1
src\build.rs        +1
src\lib.rs          0
    102 Is this really correct for specifying the *host* environment?
    105 ..
src\utils.rs        0
    14  Isn't this generating /../../../ ?  Doesn't seem right...

Cargo.toml          +1
Cargo.toml.orig     +1

Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.

To review the actual code of the crate, it's best to use cargo crev open dinghy-build. Alternatively, you can download the tarball of dinghy-build v0.7.3 or view the source online.