Lib.rs

› cargo-dinghy › Reviews

These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of cargo-dinghy is 0.7.1.

0.4.16 (older version) Rating: Positive Thoroughness: Low Understanding: Medium

by MaulingMonkey on 2019-09-17

0.4.16: Trivial version bumps. 0.4.15: Trivial version bumps. 0.4.14: Trivial version bumps, mass reformatting. 0.4.13: Trivial version bumps. 0.4.12: Trivial version bumps. 0.4.11: Nice and solid looking code. 100% safe code.

Reviewed: src\cli.rs: +1 src\main.rs: +1 151 run_lldb Nonterminating loops are problematic, but I think the side effects here should make this work OK? (see https://github.com/rust-lang/rust/issues/28728 ) Cargo.toml: +1 Cargo.toml.orig: +1 13 readme path references unpackaged readme

TIL: Using traits to extend clap::App so flags can be reused per-subcommand is interesting.

0.4.15 (older version) Rating: Positive Thoroughness: Low Understanding: Medium

by MaulingMonkey on 2019-09-17

Show review…

0.4.15: Trivial version bumps. 0.4.14: Trivial version bumps, mass reformatting. 0.4.13: Trivial version bumps. 0.4.12: Trivial version bumps. 0.4.11: Nice and solid looking code. 100% safe code.

Reviewed: src\cli.rs: +1 src\main.rs: +1 151 run_lldb Nonterminating loops are problematic, but I think the side effects here should make this work OK? (see https://github.com/rust-lang/rust/issues/28728 ) Cargo.toml: +1 Cargo.toml.orig: +1 13 readme path references unpackaged readme

TIL: Using traits to extend clap::App so flags can be reused per-subcommand is interesting.

Lib.rs has been able to verify that all files in the crate's tarball, except Cargo.lock, are in the crate's repository. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.

To review the actual code of the crate, it's best to use cargo crev open cargo-dinghy. Alternatively, you can download the tarball of cargo-dinghy v0.7.1 or view the source online.