Lib.rs

› ByteOrder › Reviews

These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.

1.5.0 — diff review from 1.4.3 only (current) safe-to-deploy

From zcash/rust-ecosystem copy of zcash/zcash. By str4d.

  • Adds two assertions to check the safety of slice::from_raw_parts_mut calls.
  • Replaces a bunch of unsafe blocks containing copy_nonoverlapping calls with safe <&mut [u8]>::copy_from_slice calls.

The current version of ByteOrder is 1.5.0.

cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.

safe-to-deploy (implies safe-to-run)

This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…

safe-to-run
Implied by other criteria

This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…

does-not-implement-crypto (implies crypto-safe)

Inspection reveals that the crate in question does not attempt to implement any cryptographic algorithms on its own.

Note that certification of this does not require an expert on all forms of cryptography: it's expected for crates we import to be "good enough" citizens, so they'll at least be forthcoming if they try to implement something cryptographic. When in doubt, please ask an expert.

crypto-safe
Implied by other criteria

All crypto algorithms in this crate have been reviewed by a relevant expert.

Note: If a crate does not implement crypto, use does-not-implement-crypto, which implies crypto-safe, but does not require expert review in order to audit for.

ub-risk-2 (implies ub-risk-3)

Negligible unsoundness or average soundness.

Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-2

ub-risk-3 (implies ub-risk-4)

Mild unsoundness or suboptimal soundness.

Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-3

ub-risk-4
Implied by other criteria

Extreme unsoundness.

Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-4

unknown

May have been packaged automatically without a review

These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of ByteOrder is 1.5.0.

1.3.4 (older version) Rating: Negative Thoroughness: Low Understanding: Medium

by MaulingMonkey on 2020-08-27

See Full Audit

Pros

  • MSRV policy!
  • Basic swizzling/endian stuff
  • You didn't have to write it

Cons

  • Excessive and distributed unsafe in serialization related code is hard to audit and makes me nervous
  • History of unsoundness. Most crate versions have alignment related bugs, and 0.2.x had overflow issues which regressed in 0.3.x.
  • Very limited functionality

1.3.4 (older version) Rating: Strong Positive Thoroughness: High Understanding: High

by gitlab.com/chrysn on 2020-04-02

There was little delta to the 1.3.2 version, but that was checked thoroughly.

1.3.4 (older version) Rating: Positive Thoroughness: Medium Understanding: Medium

by niklasf on 2020-02-27

Provides methods for encoding and decoding numbers in big-endian and little-endian order.

This is a widely used, very well tested, high quality crate.

There are two kinds of unsafe blocks:

(1) Integer/IEEE754 floating point casting. After bumping MSRV to 1.20.0 some of these can be avoided by using {f32,f64}::from_bits() from the standard library.

(2) Slice casting (via pointers). It seems to assume that for example u32, i32 and f32 have compatible alignment, which is probably valid. Maybe this should be noted in a comment.

1.3.2 (older version) Rating: Strong Positive Thoroughness: Low Understanding: Medium

by dpc on 2019-10-17

Good test coverage, good documentation. LGTM

1.3.1 (older version) Rating: Strong Positive Thoroughness: Low Understanding: Medium

by dpc on 2019-06-18

Show review…

Good test coverage, good documentation. LGTM

0.5.3 (older version) Rating: Positive Thoroughness: Medium Understanding: Medium

by tcharding on 2022-12-16

I spent about half an hour looking over this small crate, LGTM.

Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.

To review the actual code of the crate, it's best to use cargo crev open byteorder. Alternatively, you can download the tarball of byteorder v1.5.0 or view the source online.