Lib.rs

› buffered_offset_reader › Reviews

These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

0.6.0 (current) Rating: Positive Thoroughness: High Understanding: High

by MaulingMonkey on 2020-09-11

Offset read/write with &self

Pros:

  • No runtime dependencies
  • read_at(&self, ...)

Cons:

  • BufOffsetReader is a bit kludgy - u64 as usize casts should probably Err instead
  • Implementing traits directly on File makes for inconsistent seek behavior when used by reference

Full Audit

The current version of buffered_offset_reader is 0.6.0.

0.5.0 (older version) Rating: Positive Thoroughness: High Understanding: High

by MaulingMonkey on 2020-09-11

Show review…

Offset read/write with &self

Pros:

  • No runtime dependencies
  • read_at(&self, ...)

Cons:

  • BufOffsetReader is a bit kludgy - u64 as usize casts should probably Err instead
  • Implementing traits directly on File makes for inconsistent seek behavior when used by reference

Full Audit

Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.

To review the actual code of the crate, it's best to use cargo crev open buffered_offset_reader. Alternatively, you can download the tarball of buffered_offset_reader v0.6.0 or view the source online.