Lib.rs

› buffered_offset_reader › Reviews

These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

0.6.0 (current) Rating: Positive Thoroughness: High Understanding: High

by MaulingMonkey on 2020-09-11

Offset read/write with &self

Pros:

  • No runtime dependencies
  • read_at(&self, ...)

Cons:

  • BufOffsetReader is a bit kludgy - u64 as usize casts should probably Err instead
  • Implementing traits directly on File makes for inconsistent seek behavior when used by reference

Full Audit

The current version of buffered_offset_reader is 0.6.0.

0.5.0 (older version) Rating: Positive Thoroughness: High Understanding: High

by MaulingMonkey on 2020-09-11

Show review…

Offset read/write with &self

Pros:

  • No runtime dependencies
  • read_at(&self, ...)

Cons:

  • BufOffsetReader is a bit kludgy - u64 as usize casts should probably Err instead
  • Implementing traits directly on File makes for inconsistent seek behavior when used by reference

Full Audit

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.

To review the actual code of the crate, it's best to use cargo crev open buffered_offset_reader. Alternatively, you can download the tarball of buffered_offset_reader v0.6.0 or view the source online.