0.2.0 (older version) Thoroughness: Medium Understanding: Medium
by gitlab.com/chrysn on 2020-05-27
This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev
.
The current version of Blockhash is 1.0.0.
0.2.0 (older version) Thoroughness: Medium Understanding: Medium
by gitlab.com/chrysn on 2020-05-27
Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.
To review the actual code of the crate, it's best to use cargo crev open blockhash
. Alternatively, you can download the tarball of blockhash v1.0.0 or view the source online.
The implementation calculates the blockhash over an image as advertised, and passed a comparison test with the Python implementation at https://github.com/commonsmachinery/blockhash-python.
The blockhash function itself is pretty basic; its website at http://blockhash.io/ its goals compared to more complex alternatives like pHash or imgSeek.