0.20.2-0.5.0 (older version) Thoroughness: High Understanding: High
by tcharding on 2023-03-21
These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.
The current version of bitcoinconsensus is 0.106.0+26.0.
0.19.0-3 (older version) Thoroughness: Medium Understanding: Medium
by tcharding on 2022-07-14
Show review…
I am the current maintainer (but not the original author), this crate is sound to the best of my knowledge
Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.
To review the actual code of the crate, it's best to use cargo crev open bitcoinconsensus. Alternatively, you can download the tarball of bitcoinconsensus v0.106.0+26.0 or view the source online.
The crate tarball contains, among others, these files:
- obscure autoconf code, 80KB: depend/bitcoin/configure.ac
- obscure autoconf code, 20KB: depend/bitcoin/src/secp256k1/configure.ac
- obscure autoconf code, 6KB: depend/bitcoin/src/minisketch/configure.ac
This crate is a very thin layer on top of code from Bitcoin Core.