Lib.rs

› aseprite › Reviews

These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

0.1.3 (current) Rating: Positive Thoroughness: Medium Understanding: High

by MaulingMonkey on 2020-10-11

[Full Audit] Parses JSON aseprite exports

Pros:

  • Looks fairly exhaustive, self contained
  • No direct disk I/O

Cons:

  • Exahustively matchable structs make most version bumps technically breaking changes
  • Requires non-default export options (fixed in an unmerged PR)
  • Enum deserialization is brittle when it comes to new options
  • Limited maintainence

The current version of aseprite is 0.1.3.

0.1.2 (older version) Rating: Positive Thoroughness: Medium Understanding: High

by MaulingMonkey on 2020-10-11

Show review…

[Full Audit] Parses JSON aseprite exports

Pros:

  • Looks fairly exhaustive, self contained
  • No direct disk I/O

Cons:

  • Exahustively matchable structs make most version bumps technically breaking changes
  • Requires non-default export options (fixed in an unmerged PR)
  • Enum deserialization is brittle when it comes to new options
  • Limited maintainence

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.

To review the actual code of the crate, it's best to use cargo crev open aseprite. Alternatively, you can download the tarball of aseprite v0.1.3 or view the source online.