Code review of the arc-io-error crate // Lib.rs

This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

0.1.1 (current) Rating: Negative + Unmaintained Thoroughness: Low Understanding: Medium

by leo60228 on 2020-01-06

Crate returns &'static str returned from transmuting a &str, which may become unsound at any time. It also has much more code than simply storing an std::io::Error in an Arc.

Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.

To review the actual code of the crate, it's best to use cargo crev open arc-io-error. Alternatively, you can download the tarball of arc-io-error v0.1.1 or view the source online.