0.8.4 (older version) Thoroughness: Low Understanding: Medium
by weiznich on 2024-02-29
This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.
The current version of AES is 0.9.0-pre.2.
These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.
The current version of AES is 0.9.0-pre.2.
0.8.4 — diff review from 0.8.3 only (older version)
From divviup/libprio-rs. By Tim Geoghegan.
Change affects some unsafe code. The only functional change is to add an
assertion checking alignment and to change an as *mut u32 cast to a
call to std::pointer::cast.
0.8.4 — diff review from 0.8.2 only (older version)
From google/supply-chain copy of fuchsia. By David Koloski.
Audited at https://fxrev.dev/987054
0.8.4 (older version)
From kornelski/crev-proofs copy of git.savannah.gnu.org.
Packaged for Guix (crates-crypto)
0.8.3 — diff review from 0.8.2 only (older version)
From divviup/libprio-rs. Audited without comment by Brandon Pitman.
0.8.3 (older version)
From kornelski/crev-proofs copy of salsa.debian.org.
Only in debcargo (unstable). Changelog:
- Team upload.
- Package aes 0.8.3 from crates.io using debcargo 2.6.0
- Set test_is_broken for the zeroize feature, it fails to build on i386.
- Add breaks on old version of rust-zip to help britney's
0.8.2 — diff review from 0.7.5 only (older version)
From google/supply-chain copy of fuchsia. By Joshua Liebow-Feeser.
Note for reviewers of future updates to this crate: There exist internal APIs such as [1] which are safe but have undocumented safety invariants.
[1] https://fuchsia-review.git.corp.google.com/c/fuchsia/+/711365/comment/7a8cdc16_9e9f45ca/
cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.
- safe-to-deploy (implies safe-to-run)
-
This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…
- safe-to-run
Implied by other criteria
This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…
- ub-risk-2 (implies ub-risk-3)
-
Negligible unsoundness or average soundness.
Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-2
- ub-risk-3 (implies ub-risk-4)
Implied by other criteria
Mild unsoundness or suboptimal soundness.
Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-3
- ub-risk-4
Implied by other criteria
Extreme unsoundness.
Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-4
- ub-risk-1 (implies ub-risk-2)
-
Excellent soundness.
Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-1
- unknown
-
May have been packaged automatically without a review
Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.
To review the actual code of the crate, it's best to use cargo crev open aes. Alternatively, you can download the tarball of aes v0.9.0-pre.2 or view the source online.
Review Diff between 0.8.3 - 0.8.4