0.9.4 (current) Thoroughness: Medium Understanding: High
by buffet on 2022-12-22
These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev
.
0.9.4 (current) Thoroughness: Medium Understanding: High
by buffet on 2022-12-22
The current version of version_check is 0.9.4.
0.9.3 (older version) Thoroughness: Low Understanding: Medium
by Minoru on 2021-05-01
Runs rustc --verbose --version
and parses the result. The binary to run can
be overridden via an environment variable RUSTC
, which I do not consider as
a security risk since it's done at build time.
There is no unsafe
, and the code itself is mostly string mangling, so
I think this crate is okay.
0.9.2 (older version) Thoroughness: Low Understanding: High
by tokcum on 2020-06-05
No dependencies. Thorough documentation. Good test coverage.
0.9.1 (older version) Thoroughness: Low Understanding: Medium
Approved without comment by kornelski on 2020-04-20
0.1.5 (older version) Thoroughness: Low Understanding: Medium
Approved without comment by kornelski on 2019-08-09
These reviews are from cargo-vet. To add your review, set up cargo-vet
and submit your URL to its registry.
0.9.4 (current)
From google/supply-chain copy of chromium. Audited without comment by George Burgess IV.
0.9.4 (current)
From kornelski/crev-proofs copy of git.savannah.gnu.org.
Packaged for Guix (crates-io)
cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.
Inspection reveals that the crate in question does not attempt to implement any cryptographic algorithms on its own.
Note that certification of this does not require an expert on all forms of cryptography: it's expected for crates we import to be "good enough" citizens, so they'll at least be forthcoming if they try to implement something cryptographic. When in doubt, please ask an expert.
All crypto algorithms in this crate have been reviewed by a relevant expert.
Note: If a crate does not implement crypto, use does-not-implement-crypto
,
which implies crypto-safe
, but does not require expert review in order to
audit for.
This is a stronger requirement than the built-in safe-to-deploy criteria, motivated by Chromium's rule-of-two related requirements: https://chromium.googlesource.com/chromium/src/+/master/docs/security/rule-of-2.md#unsafe-code-in-safe-languages
This crate will not introduce a serious security vulnerability to production software exposed to untrusted input.
Auditors are not required to perform a full logic review of the entire crate. Rather, they must review enough to fully reason about the behavior of all unsafe blocks and usage of powerful imports. For any reasonable usage of the crate in real-world software, an attacker must not be able to manipulate the runtime behavior of these sections in an exploitable or surprising way.
Ideally, ambient capabilities (e.g. filesystem access) are hardened against
manipulation and consistent with the advertised behavior of the crate. However,
some discretion is permitted. In such cases, the nature of the discretion should
be recorded in the notes
field of the audit record.
Any unsafe code in this crate must, in general, be kept well-contained, and documentation must exist to describe how Rust's invariants are being upheld despite the unsafe block(s). Nontrivial uses of unsafe must be reviewed by an expert in Rust's unsafety guarantees/non-guarantees.
For crates which generate deployed code (e.g. build dependencies or procedural macros), reasonable usage of the crate should output code which meets the above criteria.
This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…
This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…
May have been packaged automatically without a review
Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.
To review the actual code of the crate, it's best to use cargo crev open version_check
. Alternatively, you can download the tarball of version_check v0.9.4 or view the source online.
Relatively straight forward parsing of
rustc --version
, with pretty good tests.