Lib.rs

› ThreadPool › Reviews

These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

1.8.1 (current) Rating: Positive Thoroughness: Medium Understanding: Medium

by MaulingMonkey on 2020-09-07

Simple basic thread pool

Pros:

  • Documented/tested MSRV
  • Uses basic well tested mpsc channels
  • No unsafe
  • Well tested, documented, looks solid

Cons:

  • No high performance work stealing queues to break up sync points for work submission
  • No auto-scaling options
  • Ignores OS thread pools (which might have better auto-scaling magic)
  • Unclamped use of frequently mad num_cpus crate could result in ThreadPool::default causing far too many threads resulting in OOM crashes.

Full Audit

The current version of ThreadPool is 1.8.1.

1.8.0 (older version) Rating: Positive Thoroughness: Medium Understanding: Medium

by MaulingMonkey on 2020-09-07

Show review…

Simple basic thread pool

Pros:

  • Documented/tested MSRV
  • Uses basic well tested mpsc channels
  • No unsafe
  • Well tested, documented, looks solid

Cons:

  • No high performance work stealing queues to break up sync points for work submission
  • No auto-scaling options
  • Ignores OS thread pools (which might have better auto-scaling magic)
  • Unclamped use of frequently mad num_cpus crate could result in ThreadPool::default causing far too many threads resulting in OOM crashes.

Full Audit

1.8.0 (older version) Rating: Positive Thoroughness: High Understanding: High

by dns2utf8 on 2020-04-30

solid crate

These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.

cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.

safe-to-run

This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…

does-not-implement-crypto (implies crypto-safe)

Inspection reveals that the crate in question does not attempt to implement any cryptographic algorithms on its own.

Note that certification of this does not require an expert on all forms of cryptography: it's expected for crates we import to be "good enough" citizens, so they'll at least be forthcoming if they try to implement something cryptographic. When in doubt, please ask an expert.

crypto-safe
Implied by other criteria

All crypto algorithms in this crate have been reviewed by a relevant expert.

Note: If a crate does not implement crypto, use does-not-implement-crypto, which implies crypto-safe, but does not require expert review in order to audit for.

unknown

May have been packaged automatically without a review

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball. To review the actual code of the crate, it's best to use cargo crev open threadpool. Alternatively, you can download the tarball of threadpool v1.8.1 or view the source online.